Issue [PMT-4048] - [17.5.3] Plesk Panel migrator crashes on deploying the service plans

[burnley]

1. Source
OS ‪Microsoft Windows Server 2012 R2‬
Plesk version 12.5.30 Update #71, last updated at Oct 16, 2017 02:54 PM
2. Target
OS ‪Microsoft Windows Server 2012 R2‬
Product Plesk Onyx
Version 17.5.3 Update #24, last updated on Oct 12, 2017 09:12 PM
Plesk Migrator Version: 2.11.4-0

Trying to import the service plans from 12.5.30 to 17.5.3 I get this error:
[...]
[2017-10-18 11:11:51][INFO] FINISH: Convert clients and subscriptions
[2017-10-18 11:11:51][INFO] START: Convert IP addresses
[2017-10-18 11:11:52][ERROR] Failed to convert IP addresses
Cause: Invalid IPv4 mask: 24
That is a critical error, migration was stopped.

C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend>

debug.log shows:
+|2017-10-18_11:11:51,865|I|MT|core.workflow.runner.by_subscription|||START: Convert IP addresses
+|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription|||Exception:
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription|||Traceback (most recent call last):
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\by_subscription.py", line 145, in run_multi_attempts
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| run()
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\by_subscription.py", line 134, in run
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| action.run(self._context)
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\plesk\actions\convert_ip_addresses.py", line 41, in run
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| global_context.convert_report
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\plesk\converter\ip_mapping.py", line 67, in map_ip_addresses
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| ip_type, ip_type.get_default_ip(subscription.server_raw_dump), subscription_report
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\utils\ip_utils.py", line 67, in get_default_ip
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| ip.address for ip in backup.get_system_ips()
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\dump\dump.py", line 1056, in get_system_ips
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| return [parse_system_ip(n, self.is_windows) for n in self.backup_info.findall('server/properties/system-ip')]
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\dump\data_model.py", line 105, in parse_system_ip
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| mask = collapse_ipv4_mask(mask_str)
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\utils\common\ip.py", line 190, in collapse_ipv4_mask
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| raise ValueError(messages.INVALID_IPV4_MASK % mask)
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription|||ValueError: Invalid IPv4 mask: 24
+|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription|||Exception:
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription|||Traceback (most recent call last):
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\by_subscription.py", line 177, in _run_common_action_plain
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| run_multi_attempts()
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\by_subscription.py", line 158, in run_multi_attempts
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription||| raise err
=|2017-10-18_11:11:51,881|D|MT|core.workflow.runner.by_subscription|||ValueError: Invalid IPv4 mask: 24
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||START: Uninstall migration agent files
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||FINISH: Uninstall migration agent files
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||START: Remove temporary users and SSH keys that were required to transfer files
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||FINISH: Remove temporary users and SSH keys that were required to transfer files
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||START: Remove temporary SSH keys
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||FINISH: Remove temporary SSH keys
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||START: Close SSH connections
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||FINISH: Close SSH connections
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||START: Shutdown Windows rsync servers
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||FINISH: Shutdown Windows rsync servers
+|2017-10-18_11:11:51,897|D|MT|core.workflow.runner.by_subscription|||START: Stop remote Windows agents
+|2017-10-18_11:11:51,897|D|MT|core.utils.agent_pool|||Shutdown Windows agent at 'pfw'
+|2017-10-18_11:11:51,927|D|MT|core.workflow.runner.by_subscription|||FINISH: Stop remote Windows agents
+|2017-10-18_11:11:52,460|D|MT|core.workflow.runner.base|||MIGRATOR END: %PLESK_DIR%\admin\plib\modules\panel-migrator\backend\plesk-migrator.bat deploy-hosting-plans
+|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli|||Context:
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli|||Traceback (most recent call last):
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\cli\common_cli.py", line 52, in run
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| options.method(migration.action_runner)
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\cli\migration_cli.py", line 372, in <lambda>
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| lambda runner: runner.run_entry_point('deploy-hosting-plans'),
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\base.py", line 66, in run_entry_point
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| self.run(entry_point, handle_stop_mark=self._context.options.is_allow_stop)
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\by_subscription.py", line 74, in run
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| self._run_common_actions_tree(actions_tree, handle_stop_mark=handle_stop_mark)
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\by_subscription.py", line 105, in _run_common_actions_tree
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| self._run_common_actions_tree(action, action_path, handle_stop_mark=handle_stop_mark)
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\by_subscription.py", line 105, in _run_common_actions_tree
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| self._run_common_actions_tree(action, action_path, handle_stop_mark=handle_stop_mark)
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\by_subscription.py", line 113, in _run_common_actions_tree
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| self._run_common_action_plain(action, action_path)
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| File "C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\workflow\runner\by_subscription.py", line 194, in _run_common_action_plain
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli||| raise MigrationError(full_failure_message)
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli|||MigrationError: Failed to convert IP addresses
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli|||Cause: Invalid IPv4 mask: 24
=|2017-10-18_11:11:52,460|D|MT|core.cli.common_cli|||That is a critical error, migration was stopped.
+|2017-10-18_11:11:52,460|E|MT|core.cli.common_cli|||Failed to convert IP addresses
=|2017-10-18_11:11:52,460|E|MT|core.cli.common_cli|||Cause: Invalid IPv4 mask: 24
=|2017-10-18_11:11:52,460|E|MT|core.cli.common_cli|||That is a critical error, migration was stopped.

 

[burnley]

Changing collapse_ipv4_mask() in C:\Program Files (x86)\Plesk\admin\plib\modules\panel-migrator\backend\lib\python\parallels\core\utils\common\ip.py seems to have done the trick "for me"(c). The changes attached.

 

[Mr.D]

Thank you for your feedback. We reproduced this issue and registered it as "PMT-4048".