Forwarded to devs Plesk 17.8.10 (testing) - PHP Warning using the "plesk repair" utility

[Sergio Manzi]

TITLE:

Plesk 17.8.10 (testing) - PHP Warning using the "plesk repair" utility​

PRODUCT, VERSION, OPERATING SYSTEM, ARCHITECTURE:

Plesk 17.8.10 (upgraded from 17.5.3#40)
CentOS 7.4.1708, Kernel 3.10.0-693​

PROBLEM DESCRIPTION:

Because of unrelated issues I tried to use the "plesk repair" utility and I think there is something wrong with it, probably not a major issue, but... see the output:

# plesk repair web -n

Checking Plesk version .............................................. [OK]

Checking for custom configuration templates
  Some custom configuration templates have been found. The custom
  templates have higher priority than default templates in case of
  configs generation
  Please check documentation for details:
  https://docs.plesk.com/current/redirect.html?book=advanced-administration-guide-linux&page=68693.htm
PHP Warning: str_repeat(): Second argument has to be greater than or equal to 0; File: /usr/local/psa/admin/plib/Repair/IO/Output.php, Line: 320

[WARNING]

Checking for the JkWorkersFile directive in the Apache configuration[OK]

Checking associations between domains and IP addresses .............. [OK]

Checking for corrupted reference between IP collections and
IPaddresses ......................................................... [OK]

Checking for links between APS applications and subscriptions ....... [OK]

Checking for the Zend extension declaraion in php.ini ............... [OK]

Check symbolic links for latest virtual host config files ........... [OK]

Checking for system users home directories consistency .............. [OK]

Checking for records with empty name field in the Configurations table[OK]

Checking for nginx ULIMIT value ..................................... [OK]

Checking for extra configurations in database not owned by any object [OK]

Checking the configuration of Apache modules ........................ [OK]

Repairing web server configuration .................................. [OK]

Checking the usage of PHP handlers .................................. [OK]

Error messages: 0; Warnings: 2; Errors resolved: 0

• As you can see in the "Checking for custom configuration templates" phase (and, yes, I do have some custom template...) a PHP warning is issued regarding an str_repeat() usage in /usr/local/psa/admin/plib/Repair/IO/Output.php
• Also, in the error counts it said that 2 warnings have been issued, while it should had been just one, unless also the PHP warning is accounted for.

STEPS TO REPRODUCE:

• Have some custom template (unsure if this is needed, but just to reproduce my current environment...)
• Issue the "plesk repair web -n" command

ACTUAL RESULT:

• An unexpected PHP warning
• Inconsistent errors count

EXPECTED RESULT:

• No PHP warning
• Consistent error count

ANY ADDITIONAL INFORMATION:

I also noted that the the "Repairing web server configuration" phase has been extremely slow (although the "-n" option) and there is no "Please wait" warning (which would be appreciated...)
​

YOUR EXPECTATIONS FROM PLESK SERVICE TEAM:

Confirm bug​

 

[Sergio Manzi]

Two more veeery minor aspects:

• You use the "Check symbolic links" wording, while in all other cases it is "Checking"
• If the "-n" option is used it would be better to have a more reassuring "Checking web server configuration" instead of "Repairing web server configuration"

 

[IgorG]

I confirm it is Plesk bug, PPP-35334 was reported.
Thank you for report.