Forwarded to devs Languagefiles breaks system

[Edward Dekker]

TITLE:

Language files breaks system
​

PRODUCT, VERSION, OPERATING SYSTEM, ARCHITECTURE:

Product version: Plesk Onyx 17.8.11 Update #24
Update date: 2018/10/02 03:42
Build date: 2018/09/27 08:08
OS version: CentOS 7.5.1804
Revision: f184ec1c85934ecb09cf67b41bff796c0ea05c01
Architecture: 64-bit
Wrapper version: 1.2
​

PROBLEM DESCRIPTION:

I've a problem by installing a updated language file from the Locales Manager.
And cannot fix the problem at the moment by a SSH command line.

[root@edwarddekker ~]# plesk repair -y
[2018-10-07 10:10:24.610] ERR [panel] syntax error, unexpected 'used' (T_STRING), expecting ')':
0: /usr/local/psa/admin/plib/locales/en-US/common_messages_en-US.php:15
        include()
1: /usr/local/psa/admin/plib/functions.php:729
        lmsg_load(string 'en-US', string '', boolean true)
2: /usr/local/psa/admin/plib/functions.php:811
        lmsg_impl(string 'cu_panel__repair_run_powerUser')
3: /usr/local/psa/admin/plib/functions.php:749
        lmsg_power_user(string 'cu_panel__repair_run')
4: /usr/local/psa/admin/plib/functions.php:763
        lmsg(string 'cu_panel__repair_run')
5: /usr/local/psa/admin/plib/api-common/cuRepair.php:918
        cuRepair->registerAdditionalUnixCommands()
6: /usr/local/psa/admin/plib/api-common/cuRepair.php:1058
        cuRepair->registerCommands()
7: /usr/local/psa/admin/plib/api-common/cuRepair.php:38
        cuRepair->__construct(NULL null)
8: /usr/local/psa/admin/plib/api-common/CuExecutor.php:59
        CuExecutor->execUtil(string 'cuRepair', string 'execute')
9: /usr/local/psa/admin/plib/api-common/CuExecutor.php:130
        CuExecutor->run()
10: /usr/local/psa/admin/plib/api-cli/CliUtilityRunner.php:25
        CliUtilityRunner->run()
11: /usr/local/psa/admin/plib/api-cli/CliUtilityRunner.php:36
        require_once(string '/usr/local/psa/admin/plib/api-cli/CliUtilityRunner.php')
12: /usr/local/psa/admin/plib/api-cli/repair.php:4
ERROR: ParseError: syntax error, unexpected 'used' (T_STRING), expecting ')' (common_messages_en-US.php:15)
exit status 1

ACTION:

Correct all files to a good translation and sort anything out as situated at this post. See also Input - Updated language file (Dutch)
​

ACTUAL RESULT:

Plesk system breaks at the moment.
​

REQUESTED:

A fix by commandline with SSH, and a updated ZIP file for English - United States language. Also would I asking to publish the update at the microupdates channel.
​

YOUR EXPECTATIONS FROM PLESK SERVICE TEAM:

Help with sorting out.​

 

[cepesh84]

@Edward Dekker

Thanks for your post.

Your zip archive with english locale template has corrupt files:

• Common I\en-US\common_messages_en-US.php
• Unix\en-US\conhelp_en-US.php

These files must comply with the syntax rules
PHP Syntax and Tags - w3resource

Now a file Common I\en-US\common_messages_en-US.php has a two lines which does not meet syntax requirements:

line 15
'actionlog__client_sapppkg_pool' => "User's web application", , not used?

", not used?" after a first comma should be removed

line 247
'actionlog__upgrade' => 'upgraded', ?

"?" after comma should be removed


Another incorrect file (wrong syntax) is
Unix\en-US\conhelp_en-US.php

line 1188

'l_clientslist_resource' => "Sort by resource usage criteria (overused/not overused).",)

spare ")" after comma

Please, fix these issues maunally. Both of these files are placed at /usr/local/psa/admin/plib/locales/en-US folder


Also I've attached a correct zip archive locale template to this post.
And finally i've created a bug with ID = EXTPLESK-512 to add a some validation to the installation of the locale template. This bug will be fixed in the next release of Locale Manager extension

 

[Edward Dekker]

Okay,

Than will Plesk running again?

Tonight will i make a try to fix the problems. Many thanks for your review. And did you check also my Dutch translation?

Staying in touch,
Edward Dekker

@Edward Dekker

Thanks for your post.

Your zip archive with english locale template has corrupt files:

• Common I\en-US\common_messages_en-US.php
• Unix\en-US\conhelp_en-US.php

These files must comply with the syntax rules
PHP Syntax and Tags - w3resource

Now a file Common I\en-US\common_messages_en-US.php has a two lines which does not meet syntax requirements:

line 15
'actionlog__client_sapppkg_pool' => "User's web application", , not used?

", not used?" after a first comma should be removed

line 247
'actionlog__upgrade' => 'upgraded', ?

"?" after comma should be removed


Another incorrect file (wrong syntax) is
Unix\en-US\conhelp_en-US.php

line 1188

'l_clientslist_resource' => "Sort by resource usage criteria (overused/not overused).",)

spare ")" after comma

Please, fix these issues maunally. Both of these files are placed at /usr/local/psa/admin/plib/locales/en-US folder


Also I've attached a correct zip archive locale template to this post.
And finally i've created a bug with ID = EXTPLESK-512 to add a some validation to the installation of the locale template. This bug will be fixed in the next release of Locale Manager extension

 

[Edward Dekker]

Hi,

My Plesk Onyx works again, thank you all.

Regards,
Edward Dekker

 

[Edward Dekker]

@cepesh84 I have found a very nice website and a api for all of the php checks by PHP Code Checker - Syntax Check for Common PHP Mistakes

Maybe a good way to integrate the api script into the locales manager.