Forwarded to devs Upgrade to 18.0.37 fails in step TrimPlanNames

[Hangover2]

Username: Hangover2

TITLE

Upgrade to 18.0.37 fails in step TrimPlanNames

PRODUCT, VERSION, OPERATING SYSTEM, ARCHITECTURE

Plesk Obsidian 18.0.36 to 37, Debian 10.10, x86-64

PROBLEM DESCRIPTION

Upgrade to 18.0.37 fails in step TrimPlanNames

STEPS TO REPRODUCE

Start upgrade from Plesk Obsidian 18.0.36 to 18.0.37
Plesk Edition: Web Pro Edition

ACTUAL RESULT

ERROR: Upgrade step 2021-07-01-11-34-45_TrimPlanNames.php failed with code 255 and output:
[2021-07-20 13:13:41.408] 9484:60f6afe560510 ERR [panel] Unknown action: template_reseller_update.
PHP Fatal error: Uncaught JMS\Serializer\Exception\RuntimeException: Could not decode JSON, syntax error - malformed JSON. in /opt/psa/admin/plib/vendor/jms/serializer/src/JsonDeserializationVisitor.php:240
Stack trace:
#0 /opt/psa/admin/plib/vendor/jms/serializer/src/Serializer.php(245): JMS\Serializer\JsonDeserializationVisitor->prepare('')
#1 /opt/psa/admin/plib/vendor/jms/serializer/src/Serializer.php(180): JMS\Serializer\Serializer->visit(Object(JMS\Serializer\GraphNavigator\DeserializationGraphNavigator), Object(JMS\Serializer\JsonDeserializationVisitor), Object(JMS\Serializer\DeserializationContext), '', 'json', 'Plesk\\Task\\Mana...')
#2 /opt/psa/admin/plib/Task/Manager.php(72): JMS\Serializer\Serializer->deserialize('', 'Plesk\\Task\\Mana...', 'json')
#3 /opt/psa/admin/plib/WebServerManager/Adapter/AsyncReconfiguration.php(49): Plesk\Task\Manager->createTask(Object(Plesk\Task\Manager\Request))
#4 /opt/psa/admin/plib/WebServerManager/Adapter/AsyncReconfiguration.php(21): WebServerManager_Adapter_Apache->taskManagerExe in /opt/psa/admin/plib/vendor/jms/serializer/src/JsonDeserializationVisitor.php on line 240
Fatal error: Uncaught JMS\Serializer\Exception\RuntimeException: Could not decode JSON, syntax error - malformed JSON. in /opt/psa/admin/plib/vendor/jms/serializer/src/JsonDeserializationVisitor.php:240
Stack trace:
#0 /opt/psa/admin/plib/vendor/jms/serializer/src/Serializer.php(245): JMS\Serializer\JsonDeserializationVisitor->prepare('')
#1 /opt/psa/admin/plib/vendor/jms/serializer/src/Serializer.php(180): JMS\Serializer\Serializer->visit(Object(JMS\Serializer\GraphNavigator\DeserializationGraphNavigator), Object(JMS\Serializer\JsonDeserializationVisitor), Object(JMS\Serializer\DeserializationContext), '', 'json', 'Plesk\\Task\\Mana...')
#2 /opt/psa/admin/plib/Task/Manager.php(72): JMS\Serializer\Serializer->deserialize('', 'Plesk\\Task\\Mana...', 'json')
#3 /opt/psa/admin/plib/WebServerManager/Adapter/AsyncReconfiguration.php(49): Plesk\Task\Manager->createTask(Object(Plesk\Task\Manager\Request))
#4 /opt/psa/admin/plib/WebServerManager/Adapter/AsyncReconfiguration.php(21): WebServerManager_Adapter_Apache->taskManagerExe in /opt/psa/admin/plib/vendor/jms/serializer/src/JsonDeserializationVisitor.php on line 240
Some steps of upgrade failed. Run upgrade with option --repair to rerun failed steps.
Warning: execute post install/upgrade actions
***** installing problem report *****
Warning: execute post install/upgrade actions
***** installing problem report *****
Warning: execute post install/upgrade actions
STOP plesk-core-18.0 upgrading AT Tue Jul 20 13:14:05 CEST 2021: PROBLEMS FOUND

EXPECTED RESULT

no error

ANY ADDITIONAL INFORMATION



YOUR EXPECTATIONS FROM PLESK SERVICE TEAM

Confirm bug

 

[oim37]

Same bug in Centos 7, when upgrade from 18.0.36 to 18.0.37

 

[IgorG]

Thank you.
The bug is confirmed. Internal issue PPPM-13114 has been created.

 

[pleskpanel]

Question: Will the upgrade need to be re-run or while the fix for PPPM-13114 fix it for already upgraded installs?

 

[matbcvo]

Can confirm. Same bug on CentOS Linux 7.9.2009 (Core) while upgrading from 18.0.36 to 18.0.37.

Trying to establish test connection... connected
done
===> Cumulative APS controller upgrade (final stage) has been started.
Upgrade or repair for 'apsc' (stage 'post') is not required
===> Cumulative upgrade of APS controller (final stage) has been completed.
===> Cumulative Plesk upgrade (final stage) has been started.
===> Preparing Plesk upgrade (final stage).
===> Cumulative upgrade of Plesk (final stage) has been completed.
Trying to add header to file /usr/local/psa/etc/webalizer.conf... file /usr/local/psa/etc/webalizer.conf already contains required header
SUCCESS: Upgrade step 2019-02-18-14-09-55_InstallEssentialExtensions.php was successfully done.
SUCCESS: Upgrade step 2019-04-25-14-46-58_ReportUsage.php was successfully done.
SUCCESS: Upgrade step 2020-03-19-17-13-39_UpgradeExtensions.php was successfully done.
ERROR: Upgrade step 2021-07-01-11-34-45_TrimPlanNames.php failed with code 255 and output:
PHP Fatal error: Uncaught JMS\Serializer\Exception\RuntimeException: Could not decode JSON, syntax error - malformed JSON. in /usr/local/psa/admin/plib/vendor/jms/serializer/src/JsonDeserializationVisitor.php:240
Stack trace:
#0 /usr/local/psa/admin/plib/vendor/jms/serializer/src/Serializer.php(245): JMS\Serializer\JsonDeserializationVisitor->prepare('')
#1 /usr/local/psa/admin/plib/vendor/jms/serializer/src/Serializer.php(180): JMS\Serializer\Serializer->visit(Object(JMS\Serializer\GraphNavigator\DeserializationGraphNavigator), Object(JMS\Serializer\JsonDeserializationVisitor), Object(JMS\Serializer\DeserializationContext), '', 'json', 'Plesk\\Task\\Mana...')
#2 /usr/local/psa/admin/plib/Task/Manager.php(72): JMS\Serializer\Serializer->deserialize('', 'Plesk\\Task\\Mana...', 'json')
#3 /usr/local/psa/admin/plib/WebServerManager/Adapter/AsyncReconfiguration.php(49): Plesk\Task\Manager->createTask(Object(Plesk\Task\Manager\Request))
#4 /usr/local/psa/admin/plib/WebServerManager/Adapter/AsyncReconfiguration.php(21): WebServerMa in /usr/local/psa/admin/plib/vendor/jms/serializer/src/JsonDeserializationVisitor.php on line 240

Fatal error: Uncaught JMS\Serializer\Exception\RuntimeException: Could not decode JSON, syntax error - malformed JSON. in /usr/local/psa/admin/plib/vendor/jms/serializer/src/JsonDeserializationVisitor.php:240
Stack trace:
#0 /usr/local/psa/admin/plib/vendor/jms/serializer/src/Serializer.php(245): JMS\Serializer\JsonDeserializationVisitor->prepare('')
#1 /usr/local/psa/admin/plib/vendor/jms/serializer/src/Serializer.php(180): JMS\Serializer\Serializer->visit(Object(JMS\Serializer\GraphNavigator\DeserializationGraphNavigator), Object(JMS\Serializer\JsonDeserializationVisitor), Object(JMS\Serializer\DeserializationContext), '', 'json', 'Plesk\\Task\\Mana...')
#2 /usr/local/psa/admin/plib/Task/Manager.php(72): JMS\Serializer\Serializer->deserialize('', 'Plesk\\Task\\Mana...', 'json')
#3 /usr/local/psa/admin/plib/WebServerManager/Adapter/AsyncReconfiguration.php(49): Plesk\Task\Manager->createTask(Object(Plesk\Task\Manager\Request))
#4 /usr/local/psa/admin/plib/WebServerManager/Adapter/AsyncReconfiguration.php(21): WebServerMa in /usr/local/psa/admin/plib/vendor/jms/serializer/src/JsonDeserializationVisitor.php on line 240
Some steps of upgrade failed. Run upgrade with option --repair to rerun failed steps.


Warning: execute post install/upgrade actions

***** installing problem report *****
Warning: execute post install/upgrade actions
***** installing problem report *****
Warning: execute post install/upgrade actions
STOP plesk-core-18.0 upgrading AT Wed Jul 28 16:59:34 EEST 2021: PROBLEMS FOUND
===> Configuring ProFTPD server

 

[pleskpanel]

Indeed -

My concern is that while it will be fixed for future updates will the "Run upgrade with option --repair to rerun failed steps." need to be manually run on installations that have already been upgraded?

 

[IgorG]

Fixed in Plesk Obsidian 18.0.37 Update 1